mirror of
https://github.com/arthur-pbty/arthur-os.git
synced 2026-08-02 04:37:49 +02:00
David Heinemeier Hansson
16604c67b3
Six widgets (clock, daytime, keyboardLayout, lockKeys, activeWindow, media) shipped identical copies of `function setting(name, fallback)`. Eight widgets reimplemented `readonly property bool vertical`, and three reimplemented `readonly property int barSize`. Move all three onto the BarWidget base so widgets read the same wiring everyone else gets for free. While in here, drop the dead `setting()` declaration on media.qml — it was defined but never called.
34 lines
1.4 KiB
QML
34 lines
1.4 KiB
QML
import QtQuick
|
|
import qs.Commons
|
|
|
|
// Base item every bar widget extends. Codifies the three properties the
|
|
// bar host injects into each widget slot:
|
|
// bar - the host Bar instance (foreground/background/run/etc).
|
|
// moduleName - widget's canonical id, used by the host registry to look
|
|
// up settings and to disambiguate inline IPC routes.
|
|
// settings - per-widget overrides read from shell.json's layout entry.
|
|
//
|
|
// Widgets are free to add their own properties, signals, and child items.
|
|
Item {
|
|
id: root
|
|
|
|
property QtObject bar: null
|
|
property string moduleName: ""
|
|
property var settings: ({})
|
|
|
|
// Bar geometry, lifted off the host. Widgets read these constantly to pick
|
|
// between horizontal/vertical layouts; defining them on the base keeps the
|
|
// `bar ? bar.x : fallback` ternary out of every widget body.
|
|
readonly property bool vertical: bar ? bar.vertical : false
|
|
readonly property int barSize: bar ? bar.barSize : Style.bar.sizeHorizontal
|
|
|
|
// Read a single value from this widget's inline shell.json entry, with a
|
|
// fallback for missing/null values. Every widget that takes user-tunable
|
|
// settings needs this; defining it once on the base keeps the wiring
|
|
// consistent.
|
|
function setting(name, fallback) {
|
|
var value = settings ? settings[name] : undefined
|
|
return value === undefined || value === null ? fallback : value
|
|
}
|
|
}
|