From 46365b7d4ddb24e69b3572bec4eaff8a8af63fbf Mon Sep 17 00:00:00 2001 From: Gavin Nugent Date: Mon, 11 May 2026 08:53:07 +0100 Subject: [PATCH] Scope branding image pickers to ~/Pictures, fix About transcode mode (#5733) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Scope branding image pickers to ~/Pictures, fix About transcode mode The "Set From Image" path in both Style → About and Style → Screensaver was scanning all of $HOME for *.svg / *.png and feeding the result into Walker dmenu. On a populated home directory this can be tens of thousands of entries, leaving the picker effectively unusable. Scope the picker to ${XDG_PICTURES_DIR:-$HOME/Pictures}, matching the pattern already used in omarchy-capture-screenshot. While here, drop the hardcoded --mode block from omarchy-branding-about so the About transcode falls back to the default braille mode, matching what omarchy-branding-screensaver does and what stock about.txt ships with. The reduced --width 54 stays so the result fits the fastfetch logo column. * Explain the scope of the picker --------- Co-authored-by: Gavin Nugent <245706154+28allday@users.noreply.github.com> Co-authored-by: David Heinemeier Hansson --- bin/omarchy-branding-about | 6 ++++-- bin/omarchy-branding-screensaver | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/bin/omarchy-branding-about b/bin/omarchy-branding-about index aca234de..f8bfd966 100755 --- a/bin/omarchy-branding-about +++ b/bin/omarchy-branding-about @@ -8,10 +8,12 @@ set -euo pipefail +SOURCE_DIR="${XDG_PICTURES_DIR:-$HOME/Pictures}" + case "${1:-}" in image) - image=$(omarchy-menu-file "Logo image" "$HOME" "svg png") - if [[ -n $image ]] && omarchy-transcode-ascii "$image" ~/.config/omarchy/branding/about.txt --width 54 --height 26 --mode block; then + image=$(omarchy-menu-file "Pick png/svg from $SOURCE_DIR" "${SOURCE_DIR}" "svg png") + if [[ -n $image ]] && omarchy-transcode-ascii "$image" ~/.config/omarchy/branding/about.txt --width 54 --height 26; then omarchy-launch-about >/dev/null 2>&1 fi ;; diff --git a/bin/omarchy-branding-screensaver b/bin/omarchy-branding-screensaver index 57012af8..4aaafc58 100755 --- a/bin/omarchy-branding-screensaver +++ b/bin/omarchy-branding-screensaver @@ -8,9 +8,11 @@ set -euo pipefail +SOURCE_DIR="${XDG_PICTURES_DIR:-$HOME/Pictures}" + case "${1:-}" in image) - image=$(omarchy-menu-file "Logo image" "$HOME" "svg png") + image=$(omarchy-menu-file "Pick png/svg from $SOURCE_DIR" "${SOURCE_DIR}" "svg png") if [[ -n $image ]] && omarchy-transcode-ascii "$image" ~/.config/omarchy/branding/screensaver.txt; then omarchy-launch-screensaver force >/dev/null 2>&1 fi